Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/13176#discussion_r64076959
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaCountVectorizerExample.java
---
@@ -54,6 +54,7 @@ public static void main(String[] args) {
.setOutputCol("feature")
.setVocabSize(3)
.setMinDF(2)
+ .setBinary(true)
--- End diff --
I'm neutral on it - my point is that the examples generally show "normal"
(or "default") usage, and are intended to be short, succinct illustrations of
usage. It's not necessary to show every possible param that can be set in each
example.
In this particular case, I would actually say that `binary=true` is a
slightly "unusual" use case (not completely expert but certainly not the
"normal" use case), so let's remove it from this PR.
For `relativeError`, it's not "expert" (though there's an argument that it
could be made an `expertParam`), but in almost all cases it is not necessary to
deviate from the default, so again this can be removed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
