Github user BryanCutler commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13176#discussion_r64077367
  
    --- Diff: docs/ml-features.md ---
    @@ -26,7 +26,9 @@ This section covers algorithms for working with features, 
roughly divided into t
     
     `HashingTF` is a `Transformer` which takes sets of terms and converts 
those sets into 
     fixed-length feature vectors.  In text processing, a "set of terms" might 
be a bag of words.
    -The algorithm combines Term Frequency (TF) counts with the 
    +A binary toggle parameter controls term frequency. When set to true all 
nonzero frequencies are
    +set to 1. This is especially useful for discrete probabilistic models that 
model binary counts
    +rather than integer. The algorithm combines Term Frequency (TF) counts 
with the
     [hashing trick](http://en.wikipedia.org/wiki/Feature_hashing) for 
dimensionality reduction.
    --- End diff --
    
    It might better to switch the order of these sentences, so you describe the 
algorithm first, then the optional binary parameter.
    ```
    The algorithm combines...
    A binary toggle parameter...
    ```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to