Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/11996#discussion_r64653419
--- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala ---
@@ -58,24 +60,26 @@ class TaskInfo(
var failed = false
+ var killed = false
+
private[spark] def markGettingResult(time: Long =
System.currentTimeMillis) {
gettingResultTime = time
}
- private[spark] def markSuccessful(time: Long = System.currentTimeMillis)
{
+ private[spark] def markFinished(time: Long = System.currentTimeMillis,
state: TaskState) {
--- End diff --
Can you move state to be first? We usually put default arguments last, and
then you don't need to always name the "state" argument when calling this
method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
