Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11996#discussion_r64654392
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/UIUtils.scala ---
    @@ -338,6 +338,16 @@ private[spark] object UIUtils extends Logging {
           failed: Int,
           skipped: Int,
           total: Int): Seq[Node] = {
    +    makeProgressBar(started, completed, failed, skipped, killed = 0, total)
    +  }
    +
    +  def makeProgressBar(
    --- End diff --
    
    Can you change the main makeProgressBar method to always accept a killed 
argument (and then update the 2-3 other locations where this is called to pass 
in killed = 0)? It looks like the other places that use this method (e.g., the 
streaming BatchPage UI class) have access to the correct number of killed 
tasks, so should be setting it accordingly (and it's a little cumbersome to 
have to maintain both versions of this method).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to