Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/13318#discussion_r64701926
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSortDataFormat.java
---
@@ -83,9 +84,8 @@ public void copyRange(LongArray src, int srcPos,
LongArray dst, int dstPos, int
@Override
public LongArray allocate(int length) {
- assert (length < Integer.MAX_VALUE / 2) : "Length " + length + " is
too large";
- // This is used as temporary buffer, it's fine to allocate from JVM
heap.
- return new LongArray(MemoryBlock.fromLongArray(new long[length * 2]));
+ assert (length * 2 <= buffer.size());
--- End diff --
Better error message for the assert?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
