Github user sitalkedia commented on a diff in the pull request:
https://github.com/apache/spark/pull/13318#discussion_r64782530
--- Diff:
core/src/main/java/org/apache/spark/shuffle/sort/ShuffleInMemorySorter.java ---
@@ -101,14 +94,17 @@ public void expandPointerArray(LongArray newArray) {
array.getBaseOffset(),
newArray.getBaseObject(),
newArray.getBaseOffset(),
- array.size() * (8 / memoryAllocationFactor)
+ pos * 8
--- End diff --
IMO, it will be better to use the memoryAllocationFactor. Because
otherwise, we might see unnecessary spilling due to memory under utilization.
If we change the memory allocation factor from 2 to 1.5 for TimSort, that is a
significant amount of memory considering the size of the pointer array can be
in the order of GBs for large workload.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
