Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13422#discussion_r65276971
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -357,13 +359,22 @@ class SparkContext(config: SparkConf) extends Logging
with ExecutorAllocationCli
*/
def setLogLevel(logLevel: String) {
val validLevels = Seq("ALL", "DEBUG", "ERROR", "FATAL", "INFO", "OFF",
"TRACE", "WARN")
- if (!validLevels.contains(logLevel)) {
+ // let's allow lowcase or mixed case too
+ if (!validLevels.contains(logLevel.toUpperCase)) {
--- End diff --
@srowen Thanks! The `toUpperCase` is against the user-input `logLevel`,
then check it against the `validLevels` right? `validLevels` already contain a
seq of upper case values.
But i will change `toUpperCase` to `toUpperCase(Locale.ENGLISH)`
And i will remove the `resetLogLevel`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
