Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13422#discussion_r65284657
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -357,7 +357,8 @@ class SparkContext(config: SparkConf) extends Logging
with ExecutorAllocationCli
*/
def setLogLevel(logLevel: String) {
val validLevels = Seq("ALL", "DEBUG", "ERROR", "FATAL", "INFO", "OFF",
"TRACE", "WARN")
- if (!validLevels.contains(logLevel)) {
+ // let's allow lowcase or mixed case too
+ if (!validLevels.contains(logLevel.toUpperCase(Locale.ENGLISH))) {
--- End diff --
@srowen Thanks! Oh. I see what you mean. I can move the validLevels as a
set as a static member. And I can also store the `logLevel.toUpperCase` to a
val and pass it to log4j. The reason I was passing `logLevel` as is is because
`org.apache.log4j.Level.toLevel(logLevel)` also converts it to upper case
internally.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
