Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/12836#discussion_r65562697
--- Diff: R/pkg/inst/worker/worker.R ---
@@ -27,6 +27,58 @@ elapsedSecs <- function() {
proc.time()[3]
}
+computeHelper <- function(mode, partition, serializer, deserializer, key,
--- End diff --
propose to separate this function to two functions: compute() and
outputResult(). Compute elapsed time and output elapsed time can be calculated
within these two functions.
Something like follows:
```
computeElapsedTime <- 0
outputElapsedTime <- 0
for (group in groups) {
(output, elapsed time) <- compute(group)
computeElapsedTime += elapsed time
outputElapsedTime += outputResult(output)
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
