Github user NarineK commented on a diff in the pull request:
https://github.com/apache/spark/pull/12836#discussion_r65807864
--- Diff: R/pkg/inst/worker/worker.R ---
@@ -27,6 +27,58 @@ elapsedSecs <- function() {
proc.time()[3]
}
+computeHelper <- function(mode, partition, serializer, deserializer, key,
--- End diff --
Hi @sun-rui , this is good, however time accumulation might lead to very
large numbers and numerical type limitations.
I was thinking to accumulate the diffs such as:
inputComputeDiff += compute - input and computeOutputDiff += output -
compute.
What do you think ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
