Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12836#discussion_r66697263
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/object.scala
 ---
    @@ -243,6 +243,55 @@ case class MapGroups(
         outputObjAttr: Attribute,
         child: LogicalPlan) extends UnaryNode with ObjectProducer
     
    +/** Factory for constructing new `FlatMapGroupsInR` nodes. */
    +object FlatMapGroupsInR {
    +  def apply(
    +      func: Array[Byte],
    +      packageNames: Array[Byte],
    +      broadcastVars: Array[Broadcast[Object]],
    +      schema: StructType,
    +      encoder: Expression,
    +      keyEncoder: Expression,
    +      rowEncoder: ExpressionEncoder[Row],
    --- End diff --
    
    Actually how about just using the same names as constructor parameters of 
case class `FlatMapGroupsInR` below?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to