Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/13107#discussion_r65928165
--- Diff:
core/src/main/java/org/apache/spark/shuffle/sort/ShuffleExternalSorter.java ---
@@ -72,7 +72,11 @@
private final TaskContext taskContext;
private final ShuffleWriteMetrics writeMetrics;
- /** Force this sorter to spill when there are this many elements in
memory. For testing only */
+ /**
+ * Force this sorter to spill when there are this many elements in
memory. This is to workaround
+ * the issue of timSort failing on large buffer size (SPARK-13850). The
default value is
+ * 1024 * 1024 * 1024 / 8 which allows the maximum size of the pointer
array to be 1G.
--- End diff --
That bug is fixed, could you update the comment (or changing 1G to 8G)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
