Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/13107#discussion_r65928685
--- Diff:
core/src/main/java/org/apache/spark/shuffle/sort/ShuffleExternalSorter.java ---
@@ -113,7 +117,7 @@
// Use getSizeAsKb (not bytes) to maintain backwards compatibility if
no units are provided
this.fileBufferSizeBytes = (int)
conf.getSizeAsKb("spark.shuffle.file.buffer", "32k") * 1024;
this.numElementsForSpillThreshold =
- conf.getLong("spark.shuffle.spill.numElementsForceSpillThreshold",
Long.MAX_VALUE);
+ conf.getLong("spark.shuffle.spill.numElementsForceSpillThreshold",
(1024 * 1024 * 1024 / 8));
--- End diff --
numElementsForSpillThreshold should be less than `1024 * 1024 * 1024 / 2`,
because radix sort could only use half of the memory.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
