Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/13394#discussion_r66030066
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2766,18 +2780,21 @@ setMethod("histogram",
return(histStats)
})
-#' Saves the content of the SparkDataFrame to an external database table
via JDBC
+#' Save the content of DataFrame to an external database table via JDBC.
#'
-#' Additional JDBC database connection properties can be set (...)
+#' Saves the content of the SparkDataFrame to an external database table
via JDBC. Additional JDBC
--- End diff --
I think we have had similar discussions in another PR, but I'm not sure I
follow the reasoning for L2783 to be "Save the content of" and L2785 to be
"Saves the content of" - why is one singular another plural?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
