Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/13394#discussion_r66177097
--- Diff: R/pkg/R/mllib.R ---
@@ -197,11 +197,10 @@ print.summary.GeneralizedLinearRegressionModel <-
function(x, ...) {
invisible(x)
}
-#' Make predictions from a generalized linear model
-#'
#' Makes predictions from a generalized linear model produced by glm() or
spark.glm(),
#' similarly to R's predict().
#'
+#' @title predict
--- End diff --
Shouldn't we follow a single convention for defining the title, either
using ```@title``` or using the first sentence in the description? @shivaram
do you have a preference? Looking at the Github history, I see lots of SparkR
contributors do both.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
