Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13642#discussion_r66844310
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala
---
@@ -49,16 +49,6 @@ class SQLMetricsSuite extends SparkFunSuite with
SharedSQLContext {
assert(boxingFinder.boxingInvokes.isEmpty, s"Found boxing:
${boxingFinder.boxingInvokes}")
}
- test("Normal accumulator should do boxing") {
- // We need this test to make sure BoxingFinder works.
- val l = sparkContext.accumulator(0L)
- val f = () => { l += 1L }
--- End diff --
Maybe... I am not sure what the purpose of the test was. The one that
remains still passes.
BTW the old accumulator API is definitely still tested. I'm just changing
tests that need an accumulator, not the old accumulator specifically. This
avoids deprecation warnings.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
