Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13642#discussion_r66857982
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala
---
@@ -49,16 +49,6 @@ class SQLMetricsSuite extends SparkFunSuite with
SharedSQLContext {
assert(boxingFinder.boxingInvokes.isEmpty, s"Found boxing:
${boxingFinder.boxingInvokes}")
}
- test("Normal accumulator should do boxing") {
- // We need this test to make sure BoxingFinder works.
- val l = sparkContext.accumulator(0L)
- val f = () => { l += 1L }
--- End diff --
There is no boxing in the new implementation, since LongAccumulator exposes
a method that accepts a primitive long now. Of course, I could change the test
to manually box it. But then that seems like it's defeating whatever purpose I
can imagine for the test. Is that really the right thing to do?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
