Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/13656#discussion_r66924013
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/fpm/AssociationRules.scala ---
@@ -120,6 +120,13 @@ object AssociationRules {
@Since("1.5.0")
def confidence: Double = freqUnion.toDouble / freqAntecedent
+ /**
+ * Returns the support of the rule. Current implementation would
return the number of
+ * co-occurrence of antecedent and consequent.
+ */
+ @Since("2.1.0")
+ def support: Double = freqUnion.toDouble
+
--- End diff --
Two major consideration:
1. In most definition and text books, `support` is a fraction value in
[0.0, 1.0]. It's possible for us to align with it in the future.
2. Current implementation of Association rule actually allows both
`freqUnion: Double,` and
`freqAntecedent: Double`
to be fraction value [0.0, 1.0] although they are both counts now. I
don't want to destroy the flexibility and break API in the future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
