Github user hhbyyh commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13656#discussion_r66931502
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/fpm/AssociationRules.scala ---
    @@ -120,6 +120,13 @@ object AssociationRules {
         @Since("1.5.0")
         def confidence: Double = freqUnion.toDouble / freqAntecedent
     
    +    /**
    +     * Returns the support of the rule. Current implementation would 
return the number of
    +     * co-occurrence of antecedent and consequent.
    +     */
    +    @Since("2.1.0")
    +    def support: Double = freqUnion.toDouble
    +
    --- End diff --
    
    I find it hard to just deprecating the old constructor and still keep 
`support` as a fraction if no dataset size is passed in. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to