Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13829#discussion_r67983638
  
    --- Diff: 
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java
 ---
    @@ -45,7 +45,12 @@ public BufferHolder(UnsafeRow row) {
       }
     
       public BufferHolder(UnsafeRow row, int initialSize) {
    -    this.fixedSize = 
UnsafeRow.calculateBitSetWidthInBytes(row.numFields()) + 8 * row.numFields();
    +    int bitsetWidthInBytes = 
UnsafeRow.calculateBitSetWidthInBytes(row.numFields());
    +    if (row.numFields() > (Integer.MAX_VALUE - initialSize) / 8) {
    +      throw new UnsupportedOperationException(
    +        "Cannot create BufferHolder from input UnsafeRow because it is too 
big.");
    --- End diff --
    
    `...too big` might be a bit to vague.... Can you use something like 
`...exceeds the maximum number of variables (268435455).`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to