Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13829#discussion_r68002862
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java
---
@@ -55,6 +60,11 @@ public BufferHolder(UnsafeRow row, int initialSize) {
* Grows the buffer by at least neededSize and points the row to the
buffer.
*/
public void grow(int neededSize) {
+ if (neededSize > Integer.MAX_VALUE / 2 - totalSize()) {
--- End diff --
shall we move this check into the if branch below? then we can just check
`length * 2 <= Integer.MAX_VALUE` and others can understand it very easily as
there is a `final byte[] tmp = new byte[length * 2];` next line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
