Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1886#discussion_r16061353
--- Diff: bin/spark-sql ---
@@ -53,42 +57,26 @@ function ensure_arg_number {
fi
}
-if [[ "$@" = --help ]] || [[ "$@" = -h ]]; then
+if [[ "$@" = *--help ]] || [[ "$@" = *-h ]]; then
usage
exit 0
fi
-CLI_ARGS=()
-SUBMISSION_ARGS=()
-
-while (($#)); do
- case $1 in
- -d | --define | --database | -f | -h | --hiveconf | --hivevar | -i |
-p)
- ensure_arg_number $# 2
- CLI_ARGS+=($1); shift
- CLI_ARGS+=($1); shift
- ;;
-
- -e)
- ensure_arg_number $# 2
- CLI_ARGS+=($1); shift
- CLI_ARGS+=(\"$1\"); shift
- ;;
- -s | --silent)
- CLI_ARGS+=($1); shift
- ;;
+function verifyApplicationOpts() {
--- End diff --
Maybe we can remove this and just let `SparkSQLCLIDriver` to verify these
application specific options?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
