Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1886#discussion_r16071047
--- Diff: bin/spark-shell ---
@@ -46,20 +46,20 @@ SUBMIT_USAGE_FUNCTION=usage
gatherSparkSubmitOpts "$@"
function main() {
- if $cygwin; then
- # Workaround for issue involving JLine and Cygwin
- # (see http://sourceforge.net/p/jline/bugs/40/).
- # If you're using the Mintty terminal emulator in Cygwin, may need
to set the
- # "Backspace sends ^H" setting in "Keys" section of the Mintty
options
- # (see https://github.com/sbt/sbt/issues/562).
- stty -icanon min 1 -echo > /dev/null 2>&1
- export SPARK_SUBMIT_OPTS="$SPARK_SUBMIT_OPTS -Djline.terminal=unix"
- $FWDIR/bin/spark-submit --class org.apache.spark.repl.Main
"${SUBMISSION_OPTS[@]}" spark-shell "${APPLICATION_OPTS[@]}"
- stty icanon echo > /dev/null 2>&1
- else
- export SPARK_SUBMIT_OPTS
- $FWDIR/bin/spark-submit --class org.apache.spark.repl.Main
"${SUBMISSION_OPTS[@]}" spark-shell "${APPLICATION_OPTS[@]}"
- fi
+ if $cygwin; then
+ # Workaround for issue involving JLine and Cygwin
--- End diff --
Um... I know it's not your fault, but since you're already fixing the
indentation here, would you mind to also re-indent this `if` statement with 2
spaces? Thanks :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
