Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13930#discussion_r68699881
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala ---
@@ -174,6 +175,18 @@ private[sql] class HiveSessionCatalog(
// xpath_double, xpath_float, xpath_int, xpath_long, xpath_number,
// xpath_short, and xpath_string.
override def lookupFunction(name: FunctionIdentifier, children:
Seq[Expression]): Expression = {
+ try {
+ subLookupFunction(name, children)
+ } catch {
--- End diff --
@dongjoon-hyun the current fix is quite brittle; this will fail again as
soon as we pass in an argument with a slightly different value. The Analyzer
will create casts to the proper type if we implement `ExpectsInputTypes`. So
this seems like the best course of action. It might not be the easiest fix, or
entirely possible; but I'd prefer to try this first.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
