Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/13930#discussion_r68700636
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala ---
@@ -174,6 +175,18 @@ private[sql] class HiveSessionCatalog(
// xpath_double, xpath_float, xpath_int, xpath_long, xpath_number,
// xpath_short, and xpath_string.
override def lookupFunction(name: FunctionIdentifier, children:
Seq[Expression]): Expression = {
+ try {
+ subLookupFunction(name, children)
+ } catch {
--- End diff --
@rxin . Actually, we do `createTempFunction` for the hive function on the
fly but with **different** signature (Decimal).
`makeFunctionBuilder` indeed uses `children` implicitly. That's the reason
why I rename `lookupFunction` into `subLookupFunction` and repeats the same
process with different children.
```
val builder = makeFunctionBuilder(functionName, className)
// Put this Hive built-in function to our function registry.
val info = new ExpressionInfo(className, functionName)
createTempFunction(functionName, info, builder, ignoreIfExists =
false)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
