Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13858#discussion_r68716660
--- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskLocation.scala
---
@@ -64,18 +64,21 @@ private[spark] object TaskLocation {
/**
* Create a TaskLocation from a string returned by getPreferredLocations.
- * These strings have the form [hostname] or hdfs_cache_[hostname],
depending on whether the
- * location is cached.
+ * These strings have the form executor_[hostname]_[executorid],
[hostname], or
+ * hdfs_cache_[hostname], depending on whether the location is cached.
*/
def apply(str: String): TaskLocation = {
val hstr = str.stripPrefix(inMemoryLocationTag)
if (hstr.equals(str)) {
--- End diff --
Not related to your change, but this method could be further clarified,
like by just checking upfront whether the string starts with
inMemoryLocationTag and returning that case straight away. Not required here.
The logic looks sound now that the comments are updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
