Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13858#discussion_r68722973
--- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskLocation.scala
---
@@ -64,18 +64,18 @@ private[spark] object TaskLocation {
/**
* Create a TaskLocation from a string returned by getPreferredLocations.
- * These strings have the form [hostname] or hdfs_cache_[hostname],
depending on whether the
- * location is cached.
+ * These strings have the form executor_[hostname]_[executorid],
[hostname], or
+ * hdfs_cache_[hostname], depending on whether the location is cached.
*/
def apply(str: String): TaskLocation = {
val hstr = str.stripPrefix(inMemoryLocationTag)
if (hstr.equals(str)) {
if (str.startsWith(executorLocationTag)) {
- val splits = str.split("_")
- if (splits.length != 3) {
- throw new IllegalArgumentException("Illegal executor location
format: " + str)
- }
- new ExecutorCacheTaskLocation(splits(1), splits(2))
+ val hostAndExecutorId = str.stripPrefix(executorLocationTag)
+ val splits = hostAndExecutorId.split("_", 2)
+ require(splits.length == 2, "Illegal executor location format: " +
str)
--- End diff --
You can use string interpolation here but not worth changing if that's the
only thing left
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
