Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13860#discussion_r68886986
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeSuite.scala ---
@@ -52,6 +52,23 @@ class DataTypeSuite extends SparkFunSuite {
assert(StructField("b", LongType, false) === struct("b"))
}
+ test("construct with add from StructField with comments") {
--- End diff --
Although more test is better, I think for this case we only need to test
`withComment` and `getComment`, it's obvious that other `StructField` creation
is calling `withComment`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
