Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/13860#discussion_r68887844
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeSuite.scala ---
@@ -52,6 +52,23 @@ class DataTypeSuite extends SparkFunSuite {
assert(StructField("b", LongType, false) === struct("b"))
}
+ test("construct with add from StructField with comments") {
--- End diff --
Since this PR also add two function calls `add` in `StructType`. This test
case also covers the interface changes.
I am fine if you think that test is useless. Let me know if you are OK to
keep them. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
