Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r69849225
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -237,62 +229,57 @@ public Decimal getDecimal(int ordinal, int precision,
int scale) {
@Override
public UTF8String getUTF8String(int ordinal) {
- assertIndexIsValid(ordinal);
- final int offset = getElementOffset(ordinal);
- if (offset < 0) return null;
- final int size = getElementSize(offset, ordinal);
+ if (isNullAt(ordinal)) return null;
+ final int offset = getInt(ordinal);
+ final int size = getSize(ordinal);
return UTF8String.fromAddress(baseObject, baseOffset + offset, size);
}
@Override
public byte[] getBinary(int ordinal) {
- assertIndexIsValid(ordinal);
- final int offset = getElementOffset(ordinal);
- if (offset < 0) return null;
- final int size = getElementSize(offset, ordinal);
+ if (isNullAt(ordinal)) return null;
+ final int offset = getInt(ordinal);
+ final int size = getSize(ordinal);
final byte[] bytes = new byte[size];
Platform.copyMemory(baseObject, baseOffset + offset, bytes,
Platform.BYTE_ARRAY_OFFSET, size);
return bytes;
}
@Override
public CalendarInterval getInterval(int ordinal) {
- assertIndexIsValid(ordinal);
- final int offset = getElementOffset(ordinal);
- if (offset < 0) return null;
+ if (isNullAt(ordinal)) return null;
+ final long offsetAndSize = getLong(ordinal);
--- End diff --
it's unused
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
