Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r69850185
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/UnsafeArraySuite.scala
---
@@ -18,27 +18,126 @@
package org.apache.spark.sql.catalyst.util
import org.apache.spark.SparkFunSuite
+import org.apache.spark.sql.catalyst.encoders.ExpressionEncoder
import org.apache.spark.sql.catalyst.expressions.UnsafeArrayData
+import org.apache.spark.unsafe.Platform
class UnsafeArraySuite extends SparkFunSuite {
- test("from primitive int array") {
- val array = Array(1, 10, 100)
- val unsafe = UnsafeArrayData.fromPrimitiveArray(array)
- assert(unsafe.numElements == 3)
- assert(unsafe.getSizeInBytes == 4 + 4 * 3 + 4 * 3)
- assert(unsafe.getInt(0) == 1)
- assert(unsafe.getInt(1) == 10)
- assert(unsafe.getInt(2) == 100)
+ val booleanArray = Array(false, true)
+ val shortArray = Array(1.toShort, 10.toShort, 100.toShort)
+ val intArray = Array(1, 10, 100)
+ val longArray = Array(1.toLong, 10.toLong, 100.toLong)
+ val floatArray = Array(1.1.toFloat, 2.2.toFloat, 3.3.toFloat)
+ val doubleArray = Array(1.1, 2.2, 3.3)
+
+ val intMultiDimArray = Array(Array(1, 10), Array(2, 20, 200), Array(3,
30, 300, 3000))
+ val doubleMultiDimArray = Array(
+ Array(1.1, 11.1), Array(2.2, 22.2, 222.2), Array(3.3, 33.3, 333.3,
3333.3))
+
+ test("read array") {
+ val unsafeBoolean = ExpressionEncoder[Array[Boolean]].resolveAndBind().
+ toRow(booleanArray).getArray(0)
+ assert(unsafeBoolean.isInstanceOf[UnsafeArrayData])
+ assert(unsafeBoolean.numElements == booleanArray.length)
+ booleanArray.zipWithIndex.map { case (e, i) =>
+ assert(unsafeBoolean.getBoolean(i) == e)
+ }
+
+ val unsafeShort = ExpressionEncoder[Array[Short]].resolveAndBind().
+ toRow(shortArray).getArray(0)
+ assert(unsafeShort.isInstanceOf[UnsafeArrayData])
+ assert(unsafeShort.numElements == shortArray.length)
+ shortArray.zipWithIndex.map { case (e, i) =>
+ assert(unsafeShort.getShort(i) == e)
+ }
+
+ val unsafeInt = ExpressionEncoder[Array[Int]].resolveAndBind().
+ toRow(intArray).getArray(0)
+ assert(unsafeInt.isInstanceOf[UnsafeArrayData])
+ assert(unsafeInt.numElements == intArray.length)
+ intArray.zipWithIndex.map { case (e, i) =>
+ assert(unsafeInt.getInt(i) == e)
+ }
+
+ val unsafeLong = ExpressionEncoder[Array[Long]].resolveAndBind().
+ toRow(longArray).getArray(0)
+ assert(unsafeLong.isInstanceOf[UnsafeArrayData])
+ assert(unsafeLong.numElements == longArray.length)
+ longArray.zipWithIndex.map { case (e, i) =>
+ assert(unsafeLong.getLong(i) == e)
+ }
+
+ val unsafeFloat = ExpressionEncoder[Array[Float]].resolveAndBind().
+ toRow(floatArray).getArray(0)
+ assert(unsafeFloat.isInstanceOf[UnsafeArrayData])
+ assert(unsafeFloat.numElements == floatArray.length)
+ floatArray.zipWithIndex.map { case (e, i) =>
+ assert(unsafeFloat.getFloat(i) == e)
+ }
+
+ val unsafeDouble = ExpressionEncoder[Array[Double]].resolveAndBind().
+ toRow(doubleArray).getArray(0)
+ assert(unsafeDouble.isInstanceOf[UnsafeArrayData])
+ assert(unsafeDouble.numElements == doubleArray.length)
+ doubleArray.zipWithIndex.map { case (e, i) =>
+ assert(unsafeDouble.getDouble(i) == e)
+ }
+
+ val unsafeMultiDimInt =
ExpressionEncoder[Array[Array[Int]]].resolveAndBind().
+ toRow(intMultiDimArray).getArray(0)
+ assert(unsafeMultiDimInt.isInstanceOf[UnsafeArrayData])
+ assert(unsafeMultiDimInt.numElements == intMultiDimArray.length)
+ intMultiDimArray.zipWithIndex.map { case (a, j) =>
+ val u = unsafeMultiDimInt.getArray(j)
+ assert(u.isInstanceOf[UnsafeArrayData])
+ assert(u.numElements == a.length)
+ a.zipWithIndex.map { case (e, i) =>
+ assert(u.getInt(i) == e)
+ }
+ }
+
+ val unsafeMultiDimDouble =
ExpressionEncoder[Array[Array[Double]]].resolveAndBind().
+ toRow(doubleMultiDimArray).getArray(0)
+ assert(unsafeDouble.isInstanceOf[UnsafeArrayData])
+ assert(unsafeMultiDimDouble.numElements == doubleMultiDimArray.length)
+ doubleMultiDimArray.zipWithIndex.map { case (a, j) =>
+ val u = unsafeMultiDimDouble.getArray(j)
+ assert(u.isInstanceOf[UnsafeArrayData])
+ assert(u.numElements == a.length)
+ a.zipWithIndex.map { case (e, i) =>
+ assert(u.getDouble(i) == e)
+ }
+ }
+ }
+
+ test("from primitive array") {
+ val unsafeInt = UnsafeArrayData.fromPrimitiveArray(intArray)
+ assert(unsafeInt.numElements == 3)
+ assert(unsafeInt.getSizeInBytes ==
+ ((4 + scala.math.ceil(3/64.toDouble) * 8 + 4 * 3 + 7).toInt / 8) * 8)
+ intArray.zipWithIndex.map { case (e, i) =>
+ assert(unsafeInt.getInt(i) == e)
+ }
+
+ val unsafeDouble = UnsafeArrayData.fromPrimitiveArray(doubleArray)
+ assert(unsafeDouble.numElements == 3)
+ assert(unsafeDouble.getSizeInBytes ==
+ ((4 + scala.math.ceil(3/64.toDouble) * 8 + 8 * 3 + 7).toInt / 8) * 8)
+ doubleArray.zipWithIndex.map { case (e, i) =>
+ assert(unsafeDouble.getDouble(i) == e)
+ }
}
- test("from primitive double array") {
- val array = Array(1.1, 2.2, 3.3)
- val unsafe = UnsafeArrayData.fromPrimitiveArray(array)
- assert(unsafe.numElements == 3)
- assert(unsafe.getSizeInBytes == 4 + 4 * 3 + 8 * 3)
- assert(unsafe.getDouble(0) == 1.1)
- assert(unsafe.getDouble(1) == 2.2)
- assert(unsafe.getDouble(2) == 3.3)
+ test("to primitive array") {
+ val intEncoder = ExpressionEncoder[Array[Int]].resolveAndBind()
+ val intInternalRow = intEncoder.toRow(intArray)
+ val intUnsafeArray = intInternalRow.getArray(0)
--- End diff --
we can combine these 2 lines: `val unsafeIntArray =
intEncoder.toRow(intArray).getArray(0)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
