Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/1822#discussion_r16196360
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Aggregate.scala ---
@@ -20,30 +20,31 @@ package org.apache.spark.sql.execution
import java.util.HashMap
import org.apache.spark.annotation.DeveloperApi
-import org.apache.spark.SparkContext
+import org.apache.spark.{SparkEnv, SparkContext}
import org.apache.spark.sql.catalyst.errors._
import org.apache.spark.sql.catalyst.expressions._
import org.apache.spark.sql.catalyst.plans.physical._
import org.apache.spark.sql.SQLContext
+import org.apache.spark.util.collection.ExternalAppendOnlyMap
/**
- * :: DeveloperApi ::
* Groups input data by `groupingExpressions` and computes the
`aggregateExpressions` for each
* group.
*
- * @param partial if true then aggregation is done partially on local data
without shuffling to
+ * partial if true then aggregation is done partially on local data
without shuffling to
--- End diff --
How about we add something like `Concrete subclasses of this trait must
implement the following abstract members:` and then use [wiki
syntax](https://wiki.scala-lang.org/display/SW/Syntax) to make the items into a
list.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
