Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/1822#issuecomment-52095270
This is looking better! Thanks again for working on it :)
A few more comments. Also, it would be really good if we could do some (at
least micro) benchmarks before an after for on-heap and then a comparison with
the external version. Let me know if you need some help coming up with that.
Also, one note. Since this is a pretty major change, I'll want to wait
until after the 1.1 release to merge it in. That said, really excited about it
for 1.2. You may want to rebase / merge to master to avoid getting to far
behind though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
