Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14012#discussion_r70053206
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1135,11 +1146,16 @@ object PushDownPredicate extends Rule[LogicalPlan]
with PredicateHelper {
// For each filter, expand the alias and check if the filter can be
evaluated using
// attributes produced by the aggregate operator's child operator.
- val (pushDown, stayUp) =
splitConjunctivePredicates(condition).partition { cond =>
+ val (candidates, containingNonDeterministic) =
+ splitConjunctivePredicates(condition).span(_.deterministic)
+
+ val (pushDown, rest) = candidates.partition { cond =>
val replaced = replaceAlias(cond, aliasMap)
- replaced.references.subsetOf(aggregate.child.outputSet) &&
replaced.deterministic
+ replaced.references.subsetOf(aggregate.child.outputSet)
}
+ val stayUp = rest ++ containingNonDeterministic
+
--- End diff --
Should we factor the single line that computes the stayUp predicates? Or
should we also put the computation of restãcontainingNonDeterministic into a
helper method? I'm not quite sure about that. Please tell me what should I
update, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
