Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/14012#discussion_r70244000
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1086,6 +1086,28 @@ object PruneFilters extends Rule[LogicalPlan] with
PredicateHelper {
* This heuristic is valid assuming the expression evaluation cost is
minimal.
*/
object PushDownPredicate extends Rule[LogicalPlan] with PredicateHelper {
+ /**
+ * Splits condition expressions into pushDown predicates and stayUp
predicates based on
+ * specific rules. Parts of the predicate that can be pushed beneath
must satisfy the following
+ * conditions:
+ * 1. Deterministic.
+ * 2. Placed before any non-deterministic predicates.
+ * 3. Other specific rules.
+ *
+ * @return (pushDown, stayUp)
+ */
+ private def splitPushdownPredicates(
+ condition: Expression)(specificRules: (Expression) => Boolean) = {
--- End diff --
Yea... @jiangxb1987 Sorry that I had to agree with @cloud-fan. Seems that
factoring out this method makes the code harder to understand, mostly because
the semantics of `specificRules` is quite convoluted. Could you please revert
this part? Sorry again for the trouble!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
