Github user GrahamDennis commented on the pull request:

    https://github.com/apache/spark/pull/1948#issuecomment-52257770
  
    I haven't worked out why yet, but this fails an updated version of the test 
that I added to my PR:
    
    (KryoSerializerDistributedSuite.scala)
    
    ```scala
    /*
     * Licensed to the Apache Software Foundation (ASF) under one or more
     * contributor license agreements.  See the NOTICE file distributed with
     * this work for additional information regarding copyright ownership.
     * The ASF licenses this file to You under the Apache License, Version 2.0
     * (the "License"); you may not use this file except in compliance with
     * the License.  You may obtain a copy of the License at
     *
     *    http://www.apache.org/licenses/LICENSE-2.0
     *
     * Unless required by applicable law or agreed to in writing, software
     * distributed under the License is distributed on an "AS IS" BASIS,
     * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
     * See the License for the specific language governing permissions and
     * limitations under the License.
     */
    
    package org.apache.spark.serializer
    
    import org.apache.spark.util.Utils
    
    import com.esotericsoftware.kryo.Kryo
    import org.scalatest.FunSuite
    
    import org.apache.spark.{LocalSparkContext, SparkConf, SparkContext, 
SparkEnv, TestUtils}
    import org.apache.spark.SparkContext._
    import org.apache.spark.serializer.KryoDistributedTest._
    
    class KryoSerializerDistributedSuite extends FunSuite {
    
      test("kryo objects are serialised consistently in different processes") {
        val conf = new SparkConf(false)
        conf.set("spark.serializer", 
"org.apache.spark.serializer.KryoSerializer")
        conf.set("spark.kryo.registrator", classOf[AppJarRegistrator].getName)
        conf.set("spark.task.maxFailures", "1")
    
        val jar = 
TestUtils.createJarWithClasses(List(AppJarRegistrator.customClassName))
        conf.setJars(List(jar.getPath))
    
        val sc = new SparkContext("local-cluster[2,1,512]", "test", conf)
        val original = Thread.currentThread.getContextClassLoader
        val loader = new java.net.URLClassLoader(Array(jar), 
Utils.getContextOrSparkClassLoader)
        SparkEnv.get.serializer.setDefaultClassLoader(loader)
    
        val cachedRDD = sc.parallelize((0 until 10).map((_, new 
MyCustomClass)), 3).cache()
    
        // Randomly mix the keys so that the join below will require a shuffle 
with each partition
        // sending data to multiple other partitions.
        val shuffledRDD = cachedRDD.map { case (i, o) => (i * i * i - 10 * i * 
i, o)}
    
        // Join the two RDDs, and force evaluation
        assert(shuffledRDD.join(cachedRDD).collect.size == 1)
    
        LocalSparkContext.stop(sc)
      }
    }
    
    object KryoDistributedTest {
      class MyCustomClass
      
      class AppJarRegistrator extends KryoRegistrator {
        override def registerClasses(k: Kryo) {
          val classLoader = Thread.currentThread.getContextClassLoader
          k.register(Class.forName(AppJarRegistrator.customClassName, true, 
classLoader))
        }
      }
    
      object AppJarRegistrator {
        val customClassName = "KryoSerializerDistributedSuiteCustomClass"
      }
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to