Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14204#discussion_r71997820
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/ExecutorData.scala ---
    @@ -34,5 +34,6 @@ private[cluster] class ExecutorData(
        override val executorHost: String,
        var freeCores: Int,
        override val totalCores: Int,
    -   override val logUrlMap: Map[String, String]
    -) extends ExecutorInfo(executorHost, totalCores, logUrlMap)
    +   override val logUrlMap: Map[String, String],
    +   override val workerUrl: Map[String, String]
    +) extends ExecutorInfo(executorHost, totalCores, logUrlMap, workerUrl)
    --- End diff --
    
    Let me also ping @JoshRosen about this change since it is adding a new 
field to `ExecutorInfo`. 
    
    @JoshRosen Does this change look good to you?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to