Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14204#discussion_r72121585
--- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala ---
@@ -934,7 +935,8 @@ private[spark] object JsonProtocol {
val executorHost = (json \ "Host").extract[String]
val totalCores = (json \ "Total Cores").extract[Int]
val logUrls = mapFromJson(json \ "Log Urls").toMap
- new ExecutorInfo(executorHost, totalCores, logUrls)
+ val worker = mapFromJson(json \ "Worker").toMap
--- End diff --
This is a compatibility concern, actually: in order to handle replay of old
logs, we need to treat this field as optional. See the examples in this file
plus the block comment at the top of `JsonProtocol` for instructions. Make sure
to add a test case which exercises the backwards-compatibility path, too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
