Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/1632#discussion_r16323402
--- Diff:
core/src/main/scala/org/apache/spark/network/ConnectionManager.scala ---
@@ -61,17 +62,17 @@ private[spark] class ConnectionManager(
var ackMessage: Option[Message] = None
def markDone(ackMessage: Option[Message]) {
- this.synchronized {
- this.ackMessage = ackMessage
- completionHandler(this)
- }
+ this.ackMessage = ackMessage
+ completionHandler(this)
}
}
private val selector = SelectorProvider.provider.openSelector()
+ private val ackTimeoutMonitor = new Timer("AckTimeoutMonitor", true)
// default to 30 second timeout waiting for authentication
private val authTimeout =
conf.getInt("spark.core.connection.auth.wait.timeout", 30)
+ private val ackTimeout =
conf.getInt("spark.core.connection.ack.wait.timeout", 60)
--- End diff --
This should be documented in doc/configuration.md. When users expect long
GC pauses, they may wish to increase timeouts across the board, so it's
important that all timeout options are documented.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
