Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/1632#discussion_r16323512
--- Diff:
core/src/main/scala/org/apache/spark/network/ConnectionManager.scala ---
@@ -652,19 +654,21 @@ private[spark] class ConnectionManager(
}
}
if (bufferMessage.hasAckId()) {
- val sentMessageStatus = messageStatuses.synchronized {
+ messageStatuses.synchronized {
messageStatuses.get(bufferMessage.ackId) match {
case Some(status) => {
messageStatuses -= bufferMessage.ackId
- status
+ status.markDone(Some(message))
}
case None => {
+ if (isAckTimeout) {
+ logWarning(s"Ack message ${message.id} maybe received
after timeout")
+ }
--- End diff --
I think, the situation receiving non-referenced message is not critical, we
should not throw Exception at least so I think log warn is better when
receiving non-referenced message even if the message is late arriving ack or
not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
