GitHub user vanzin opened a pull request:
https://github.com/apache/spark/pull/14468
[SPARK-16671][core][sql] Consolidate code to do variable substitution.
Both core and sql have slightly different code that does variable
substitution
of config values. This change refactors that code and encapsulates the logic
of reading config values and expading variables in a new helper class, which
can be configured so that both core and sql can use it without losing
existing
functionality, and allows for easier testing and makes it easier to add more
features in the future.
Tested with existing and new unit tests, and by running spark-shell with
some configs referencing variables and making sure it behaved as expected.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vanzin/spark SPARK-16671
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/14468.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14468
----
commit 9d88d871538a577ddab439858e1fc016c8737f09
Author: Marcelo Vanzin <[email protected]>
Date: 2016-08-02T20:41:32Z
[SPARK-16671][core][sql] Consolidate code to do variable substitution.
Both core and sql have slightly different code that does variable
substitution
of config values. This change refactors that code and encapsulates the logic
of reading config values and expading variables in a new helper class, which
can be configured so that both core and sql can use it without losing
existing
functionality, and allows for easier testing and makes it easier to add more
features in the future.
Tested with existing and new unit tests, and by running spark-shell with
some configs referencing variables and making sure it behaved as expected.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
