Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9571#discussion_r73623629
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala ---
@@ -114,28 +123,45 @@ class HistoryServer(
* this UI with the event logs in the provided base directory.
*/
def initialize() {
- attachPage(new HistoryPage(this))
+ if (!initialized.getAndSet(true)) {
--- End diff --
If that's the case, `initialize()` should be made private and its calls
removed from the tests.
(I've seen this pattern of calling an `init()` method from constructors in
Scala when the initialization code requires local variables, which otherwise
would have to be fields in the class...)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
