Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9571#discussion_r73624457
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala ---
@@ -226,6 +259,135 @@ class HistoryServer(
}
/**
+ * An abstract implementation of the metrics [[Source]] trait with some
common operations.
+ */
+private[history] abstract class HistoryMetricSource(val prefix: String)
extends Source {
--- End diff --
Can you put this class (and the new gauges you're adding) in a new source
file? They're not specific to `HistoryServer` so it's better to have them in a
separate place.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
