Github user eyalfa commented on the issue:
https://github.com/apache/spark/pull/14444
I've executed the entire test suits tree of the catalyst projects and seen
failures.
Some of these fail, the most notables are the ast-builder and
expression-encoder that failed on attempts to evaluate or extract the
dataType of an unresolved tree.
There was also another test that tested createStruct's evaluation
directly,i've changed it to be ignored.
It is possible that the ast-builder tester should be changed rather than
the component itself,but I've seen it fail in createStruct.dataType.
The expression-encoder seems to be building expressions and evaluate the
directly (couldn't see a call to the analyzer or optimizer there),it made
me believe it assumes that all created expressions are valid and resolved -
so I made sure it continues to work with resolved expressions.
On Aug 5, 2016 7:09 AM, "Wenchen Fan" <[email protected]> wrote:
> Why? I think we only need to touch Analyzer and remove the execution
> logic from CreateStruct. Wherever we create CreateStruct, we just keep
> it, but replace(or resolve) it in Analyzer.
>
> â
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/spark/pull/14444#issuecomment-237750519>, or
mute
> the thread
>
<https://github.com/notifications/unsubscribe-auth/ABFFOWo3KQDiJbyN0lkz-2pS51Mt-1JCks5qcrdkgaJpZM4JaDJr>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
