Github user eyalfa commented on the issue:
https://github.com/apache/spark/pull/14444
I think we need createStruct first of all for backward compatibility and
second because some constructs (such as row creator) maps directly into its
structure.
I think that the way ast-builder handles the inline table is wrong as it
mixes parsing and validation in a single pass, I think it could produce
some unresolved structure (UnresolvedInlineTable?) Which can be later
resolved by the analyzer,this would also produce better and clearer
validation errors. I.e. by looking at antlr grammar,it seems that
row-constructor isn't really limited to constant expressions, I haven't
tried but I guess it's possible to come up with an input that crashes it in
a bad way.
Regarding the expressionEncoder,the more I look at its usage and the more I
consider the fact that Dataset's suit is passing,the more I believe I
should revert my changes to expressionEncider and actually fix it's test
code (pass the tree to the analyzer prior to comparing/evaluating it).
On Aug 7, 2016 8:14 PM, "Herman van Hovell" <[email protected]>
wrote:
> First (hopefully dumb) question: why is this needed?
>
> Maybe I am missing something: Shouldn't we just ban CreateStruct (and its
> unsafe brother)? Why keep these around if we are going to rewrite them
> anyway?
>
> As for visitTable. You could also write this into a Union of a number of
Project(...,
> OneRowRelation) statements, if that makes life easier.
>
> â
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/spark/pull/14444#issuecomment-238094803>, or
mute
> the thread
>
<https://github.com/notifications/unsubscribe-auth/ABFFObKP7xmdAkvIhkuU8w1XQtT4OCV9ks5qdhJbgaJpZM4JaDJr>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
