Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1919#discussion_r16340258
--- Diff: sql/hive/src/main/scala/org/apache/spark/SparkHadoopWriter.scala
---
@@ -93,6 +93,33 @@ private[hive] class SparkHiveHadoopWriter(
null)
}
+ def open(dynamicPartPath: String) {
+ val numfmt = NumberFormat.getInstance()
--- End diff --
Just realized this function is a variant of the original `open()` method
within the same file. This should be a bug in the master branch.
Another issue is that, `SparkHadoopWriter` resides in project `core`, which
is an indirect dependency of `sql/hive`. Thus logically, it's not proper to put
`open(dynamicPartPath: String)` here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
