Github user junyangq commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14558#discussion_r74728351
  
    --- Diff: R/pkg/R/mllib.R ---
    @@ -142,15 +143,6 @@ setMethod("spark.glm", signature(data = 
"SparkDataFrame", formula = "formula"),
     #' Generalized Linear Models (R-compliant)
     #'
     #' Fits a generalized linear model, similarly to R's glm().
    -#' @param formula A symbolic description of the model to be fitted. 
Currently only a few formula
    --- End diff --
    
    Well yes we agree on that. The reason I moved these is because I thought 
when `setGeneric("glm")` is called, it looks for the R glm method and it 
includes many arguments. Some overlap with `glm` defined for SparkDataFrame. 
Then I simply moved all the argument docs to the generic part, though that 
makes the doc there cumbersome...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to