Github user junyangq commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14558#discussion_r74729338
  
    --- Diff: R/pkg/R/DataFrame.R ---
    @@ -510,9 +510,7 @@ setMethod("registerTempTable",
     #'
     #' Insert the contents of a SparkDataFrame into a table registered in the 
current SparkSession.
     #'
    -#' @param x A SparkDataFrame
    -#' @param tableName A character vector containing the name of the table
    --- End diff --
    
    The reasons are
    
    1. It's generic counterpart has `...` and we have to document for that.
    
    2. I think it may be preferred that `...` follows other explicit arguments 
in order?
    
    Does that make sense?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to