Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2002#discussion_r16383881
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -451,10 +451,56 @@ private[spark] object Utils extends Logging {
/**
* Get a temporary directory using Spark's spark.local.dir property, if
set. This will always
* return a single directory, even though the spark.local.dir property
might be a list of
- * multiple paths.
+ * multiple paths. If the SPARK_LOCAL_DIRS environment variable is set,
then this will return
+ * a directory from that variable.
*/
def getLocalDir(conf: SparkConf): String = {
- conf.get("spark.local.dir",
System.getProperty("java.io.tmpdir")).split(',')(0)
+ getOrCreateLocalRootDirs(conf)(0)
+ }
+
+ /**
+ * Gets or creates the directories listed in spark.local.dir or
SPARK_LOCAL_DIRS,
+ * and returns only the directories that exist / could be created.
+ */
+ private[spark] def getOrCreateLocalRootDirs(conf: SparkConf):
Array[String] = {
+ val isYarn = java.lang.Boolean.valueOf(
+ System.getProperty("SPARK_YARN_MODE",
conf.getenv("SPARK_YARN_MODE")))
--- End diff --
SPARK_YARN_USER_ENV is optional. We could make sure some other env
variable is always set when we launch a container in yarn though.
I was looking for something else we could use that would be reliable. For
instance, you could use the LOCAL_DIRS or YARN_LOCAL_DIRS as an indicator since
YARN always set those. But LOCAL_DIRS is generic enough I guess a user could
have it set for something else. There are other variables that YARN sets for
you. I think what might be a good idea is to check to see if either
CONTAINER_ID or NM_HOST are set. The reason to check for both is hadoop 2.x
sets CONTAINER_ID which I prefer to use but hadoop 0.23 doesn't and NM_HOST is
set on both.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
