Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2002#discussion_r16384235
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -451,10 +451,56 @@ private[spark] object Utils extends Logging {
/**
* Get a temporary directory using Spark's spark.local.dir property, if
set. This will always
* return a single directory, even though the spark.local.dir property
might be a list of
- * multiple paths.
+ * multiple paths. If the SPARK_LOCAL_DIRS environment variable is set,
then this will return
+ * a directory from that variable.
*/
def getLocalDir(conf: SparkConf): String = {
- conf.get("spark.local.dir",
System.getProperty("java.io.tmpdir")).split(',')(0)
+ getOrCreateLocalRootDirs(conf)(0)
+ }
+
+ /**
+ * Gets or creates the directories listed in spark.local.dir or
SPARK_LOCAL_DIRS,
+ * and returns only the directories that exist / could be created.
+ */
+ private[spark] def getOrCreateLocalRootDirs(conf: SparkConf):
Array[String] = {
+ val isYarn = java.lang.Boolean.valueOf(
+ System.getProperty("SPARK_YARN_MODE",
conf.getenv("SPARK_YARN_MODE")))
--- End diff --
> We could make sure some other env variable is always set when we launch a
container in yarn though.
Yeah, that was my suggestion: set a new variable, say, IN_YARN_CONTAINER,
using the same code path that we use to expose SPARK_YARN_USER_ENV to the
container. Will this work, though? Does _every_ container that we launch go
through this code path, including workers and the Spark driver (if running in
yarn-cluster mode)?
> I think what might be a good idea is to check to see if either
CONTAINER_ID or NM_HOST are set.
I considered an approach like this, too (but I didn't know which variables
to use), but it might be safer to set our own variable and not have to worry
about compatibility across YARN versions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
